-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: fix when path is buffer #34540
Closed
Closed
fs: fix when path is buffer #34540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
Issues and PRs related to the fs subsystem / file system.
label
Jul 28, 2020
jasnell
approved these changes
Jul 28, 2020
6 tasks
MrHeer
approved these changes
Jul 29, 2020
antsmartian
approved these changes
Jul 29, 2020
antsmartian
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jul 29, 2020
rexagod
approved these changes
Jul 29, 2020
This was referenced Jul 29, 2020
himself65
added a commit
to himself65/node
that referenced
this pull request
Jul 30, 2020
PR-URL: nodejs#34540 Fixes: nodejs#34514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]>
Landed in 2c4f30d |
Trott
reviewed
Jul 30, 2020
This was referenced Jul 31, 2020
13 tasks
@himself65 could you please manually backport this to v14.x? It caused a new deterministic failure:
and i'm not quite sure why. |
Merged
targos
removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-requested-v14.x
labels
Apr 30, 2021
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #34540 Fixes: #34514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34514
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes